Merged
Conversation
Provides guidance for Claude Code including build commands, the three-stage converter pipeline (Parser → MIL Builder → Serializer), key types, and KataGo model version support details. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add min_batch_size, max_batch_size options to ConversionOptions - Implement setBatchDimension() in MILBuilder for dynamic batch - Add ShapeRange support in CoreMLSerializer for flexible inputs - Add --dynamic-batch CLI option to katago2coreml - Add BatchSizeTests.cpp unit tests (5 tests) - Add verify_output_error.py for cross-validation - Fix 4 reshape operations for batch > 1 compatibility Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add three KataGo test models to tests/models/ (22 MB total) - g170e-b10c128: Standard test model (11 MB) - g170-b6c96: Smaller/faster test model (3.7 MB) - b5c192nbt-distilled: Distilled model with metadata encoder (7 MB) - Add tests/models/README.md with licensing and usage documentation - Clear attribution for g170 models (CC0/public domain) - License information for b5c192nbt-distilled model (BSD-3-Clause) - Reference info for other KataGo models (MIT-style) - Update NOTICE with model license information - Update CLAUDE.md and README.md with testing documentation - Document C++ unit tests (ctest) - Document Python integration tests (pytest) - Include model requirements and usage instructions - Update tests/conftest.py for standalone repository structure - Fix paths to work with katagocoreml-cpp standalone repo - Update model directory to tests/models/ - Add Python-specific ignores to .gitignore - Ignore __pycache__/ directories - Remove checked-in .pyc files - Remove TODO comment from ParserTests.cpp (now resolved) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add comprehensive CI workflow that builds, tests, and validates the katagocoreml-cpp project on macOS. The workflow includes: - Dependency installation (cmake, protobuf, abseil, zlib) - C++ unit tests with CTest - Real model conversion test using KataGo models - Package structure validation - Installation verification Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Remove --batch-size and --precision options that don't exist in katago2coreml CLI. The tool uses --dynamic-batch for batching and --float16 for precision control. Default settings are sufficient for the CI test (batch size 1, FLOAT32 precision). Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add comprehensive documentation for the --dynamic-batch CLI option and min_batch_size/max_batch_size API fields. Include usage examples for bounded and unbounded batch sizes, and performance considerations. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Implements comprehensive dynamic batch size testing for C++ converter: - Add TestCppDynamicBatch class with parametrized tests for (1,4), (1,8), and unlimited batch configs - Create deterministic batched inputs helper with per-sample seed consistency - Extend convert_with_cpp helper to support min_batch_size/max_batch_size parameters - Validate dynamic batch models produce numerically equivalent outputs to fixed baseline - Add defensive shape validation and enhanced error messages - Fix input generation to ensure consistent seeds between batched and individual samples - Extract RANDOM_SEED_BASE constant and add proper type hints - Add input validation and overflow protection CI workflow improvements: - Remove pre-installed dependencies (cmake, zlib) from brew install - Document which dependencies are pre-installed on GitHub runners Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Increments converter version from 1.0.0 to 1.1.0 following semantic versioning for the new backwards-compatible dynamic batch size feature. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
min_batch_size,max_batch_sizeoptions toConversionOptionssetBatchDimension()in MILBuilder for dynamic batch supportShapeRangesupport in CoreMLSerializer for flexible input shapes--dynamic-batch <min,max>CLI option to katago2coremlBug Fixes
Fixed 4 reshape operations that used incompatible shapes for batch > 1:
Test plan
Usage
🤖 Generated with Claude Code