Add self-validation test for FP16 I/O vs mixed precision#6
Merged
ChinChangYang merged 2 commits intomasterfrom Jan 19, 2026
Merged
Add self-validation test for FP16 I/O vs mixed precision#6ChinChangYang merged 2 commits intomasterfrom
ChinChangYang merged 2 commits intomasterfrom
Conversation
Add TestCppMixedVsPureFP16 test class that compares pure FP16 I/O outputs against mixed precision outputs, since Python coremltools doesn't support float16_io mode. Also clarify comments in MILBuilder.cpp explaining that _fp16 suffixed names are intermediate operation names that cast ops later rename to base names for final model outputs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace absolute tolerance (max diff > 0.5) with np.allclose using rtol=1e-2 and atol=1e-2 for more robust FP16 comparison that handles both relative and absolute differences appropriately. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestCppMixedVsPureFP16test class that validates pure FP16 I/O mode produces inference results equivalent to mixed precision mode_fp16suffix for intermediate ops; cast ops rename to base name)Test plan
pytest tests/test_cpp_vs_python.py::TestCppMixedVsPureFP16 -von Apple Silicon🤖 Generated with Claude Code