Skip to content

Improve custom scanner feature#148

Merged
Chrisimx merged 7 commits intomainfrom
custom-scanners-improvements
Mar 12, 2026
Merged

Improve custom scanner feature#148
Chrisimx merged 7 commits intomainfrom
custom-scanners-improvements

Conversation

@Chrisimx
Copy link
Owner

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the “custom scanner” workflow by introducing edit and delete capabilities, improving dialogs, and updating related strings so users can manage saved custom scanners more directly from the scanner browser UI.

Changes:

  • Add edit + delete actions for saved custom scanners (including a deletion confirmation dialog).
  • Extend dialogs to support “new vs edit” behavior and reuse deletion dialog with custom title/text.
  • Update/extend localized string resources (EN/DE/IT) for the new UI.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
app/src/main/res/values/strings.xml Adds new strings for save/edit/delete and renames the custom-scanner dialog title key.
app/src/main/res/values-it/strings.xml Italian translations for the new save/edit/delete strings and updated dialog title key.
app/src/main/res/values-de/strings.xml German translations for the new save/edit/delete strings and updated dialog title key.
app/src/main/java/io/github/chrisimx/scanbridge/uicomponents/dialog/DeleteDialog.kt Generalizes deletion dialog (custom title/body) and styles destructive actions in error color.
app/src/main/java/io/github/chrisimx/scanbridge/uicomponents/dialog/CustomScannerDialog.kt Adds “new vs edit” mode with pre-filled fields and different button sets (connect vs save).
app/src/main/java/io/github/chrisimx/scanbridge/uicomponents/FoundScannerItem.kt Adds edit + delete icon buttons for saved custom scanners and adjusts layout.
app/src/main/java/io/github/chrisimx/scanbridge/db/daos/CustomScannerDao.kt Adds UUID-based fetch/delete DAO methods and enables REPLACE on insert for updates.
app/src/main/java/io/github/chrisimx/scanbridge/data/ui/CustomScannerViewModel.kt Adds UUID-based delete and a UUID-based load helper.
app/src/main/java/io/github/chrisimx/scanbridge/data/model/EditedCustomScanner.kt Introduces a sealed model to represent “new” vs “editing existing” custom scanners.
app/src/main/java/io/github/chrisimx/scanbridge/StartupScreen.kt Switches dialog state from boolean to an EditedCustomScanner? to support edit/new modes.
app/src/main/java/io/github/chrisimx/scanbridge/ScanningScreen.kt Updates deletion dialog call site to pass title/body resources.
app/src/main/java/io/github/chrisimx/scanbridge/ScannerBrowser.kt Wires edit + delete flows into the scanner browser, including deletion confirmation and edit-save behavior.
app/src/androidTest/java/io/github/chrisimx/scanbridge/screenshot/ScanBridgeScreenshotTest.kt Cleans up formatting/imports in screenshot tests.
app/src/androidTest/java/io/github/chrisimx/scanbridge/ScanBridgeTest.kt Cleans up unused imports in android tests.
app/build.gradle.kts Removes unused imports / whitespace cleanup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@Chrisimx Chrisimx merged commit bbd56d0 into main Mar 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants