Convert :get-configuration to GetConfigurationCommand (#392)#19
Open
ChrisonSimtian wants to merge 2 commits into
Open
Convert :get-configuration to GetConfigurationCommand (#392)#19ChrisonSimtian wants to merge 2 commits into
ChrisonSimtian wants to merge 2 commits into
Conversation
Lift the :get-configuration handler into a standalone IFalloutCommand type. The shared GetConfiguration(buildScript, evaluate) helper (also used by add-package, update and cake) stays on Program as internal residual until the Fallout-build#392 collapse PR extracts it into a configuration service. Replaces the DelegateCommand adapter. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Name resolution and parsing a build script CONFIGURATION block. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of Fallout-build#392 (one command per PR). Stacked on #16 — merge after it lands.
Lifts
:get-configurationintoGetConfigurationCommand : IFalloutCommand. The sharedGetConfiguration(buildScript, evaluate)helper (also used by add-package/update/cake) stays onProgramasinternalresidual until the collapse PR (#26) moves it into a configuration service. Replaces theDelegateCommandadapter. Name/behaviour unchanged.Re-raised fork-internally to move the cli-cmd stack off the main repo. Supersedes Fallout-build#397; same history and diff.
🤖 Generated with Claude Code