Convert :cake-convert and :cake-clean to command types (#392)#24
Open
ChrisonSimtian wants to merge 3 commits into
Open
Convert :cake-convert and :cake-clean to command types (#392)#24ChrisonSimtian wants to merge 3 commits into
ChrisonSimtian wants to merge 3 commits into
Conversation
Lift the two cake handlers into CakeConvertCommand and CakeCleanCommand (discrete commands, names preserved) taking IConsolePrompts via the constructor. The .cake syntax-rewriting helpers (GetCakeFiles/GetCakeConvertedContent/GetCakePackages) stay on Program as internal residual — GetCakeConvertedContent/GetCakePackages are exercised directly by the Cake conversion tests — until the Fallout-build#392 collapse PR. Replaces both DelegateCommand adapters. Tests: 30 pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Name resolution and the decline-delete path (returns 0, removes nothing). CakeConvertCommand is integration-only (initializes MSBuild), tested via the existing Cake conversion tests rather than a command unit test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: ITaluone <44049228+ITaluone@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of Fallout-build#392. Stacked on #16 — merge after it lands.
Per the locked decision, cake's two verbs become discrete commands with names preserved:
CakeConvertCommand(cake-convert) andCakeCleanCommand(cake-clean), both takingIConsolePromptsvia the constructor. The.cakerewriting helpers (GetCakeFiles/GetCakeConvertedContent/GetCakePackages) stay onProgramasinternalresidual (exercised by the Cake tests) until the collapse PR (#26). Replaces bothDelegateCommandadapters.Verification
Fallout.Cli.Tests30 pass.Re-raised fork-internally to move the cli-cmd stack off the main repo. Supersedes Fallout-build#402; same history and diff.
🤖 Generated with Claude Code