Open
Conversation
thiagofigueiro
commented
Sep 11, 2021
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| ARG TZ | ||
| ENV TZ=${TZ:-America/New_York} |
Author
There was a problem hiding this comment.
We can actually remove the TZ environment variable since it's only used for the build. I might do this in another MR.
thiagofigueiro
commented
Sep 11, 2021
| RUN ln -snf /usr/share/zoneinfo/$TZ /etc/localtime \ | ||
| && dpkg-reconfigure -f noninteractive tzdata | ||
|
|
||
| RUN pip install requests loguru pillow |
Author
There was a problem hiding this comment.
I moved this because it's usual to have the setup steps before the CMD.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, @Christofo. Thanks for sharing this project.
I decided not to run the docker containers on the Synology device since I have a better server available on my network. The setup is the same, other than the network address user in the Synology webhook.
This pull request contains my
docker-compose.ymland other related files. While I was at it, I updated theDockerfileto parametrise the time zone (can still be improved but it's a start), and to update the OS packages when building.I intend to add an automated setup script to your project so the Synology configuration doesn't need to be manually done. As part of that I'd like to add some unit tests and CI configuration to make sure I'm not breaking anything.
Please let me know if you would like me to send these contributions back to your repository.