Add error handling to deal with unexpected filter types (incompatibil…#7
Open
lieszkol wants to merge 1 commit intoChristophKaser:masterfrom
Open
Add error handling to deal with unexpected filter types (incompatibil…#7lieszkol wants to merge 1 commit intoChristophKaser:masterfrom
lieszkol wants to merge 1 commit intoChristophKaser:masterfrom
Conversation
…ity with FiltaQuilla or QuickFilters?) Perhaps due to incompatibility with FiltaQuilla or QuickFilters, the "Filters" add-on would completely stop working after certain special filters were defined. Adding some error handling to enable the add-on to continue functioning even in such cases.
Owner
|
Thank you very much for your contribution! Can you tell me more about the filter that causes the exception so I can try to reproduce the issue? |
Author
|
I'm not familiar with the workings of the plugin, I am sure there is a better way to handle these errors. Unfortunately I have many filters and I was unable to idenfity which of them where throwing the exceptions. I suspect it may be one of the FiltaQuilla custom actions, which are quite useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ity with FiltaQuilla or QuickFilters?)
Perhaps due to incompatibility with FiltaQuilla or QuickFilters, the "Filters" add-on would completely stop working after certain special filters were defined. I propose adding some error handling to enable the add-on to continue functioning even in such cases.