Merged
Conversation
Owner
Author
|
@sritchie This is published on npm as Besides |
Contributor
|
The few I have after scanning all of the examples are background color and alpha, and also properties on the controls instance. Will send more when I'm at the computer but those are the main ones. Feels like this might be a nice pattern for any of the threestrap plug-in properties. |
b35bb61 to
a91a8b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to discussions in #24, unconed/mathbox#57 (comment)
This adds some new exports, available from
mathbox-react/three. Right now the only export there is aRenderercomponent which allows settingclearColor:Some comments:
mathbox-react/threestrapsince, unlike almost all1 other mathbox-react component exports, these don't correspond to a mathbox node.Rendereris just an example, and it probably should have some more props. Other similar components might beOrbitControls, or other controls-components.Footnotes
I say "almost all" because of the ContainedMathbox and Mathbox components, which don't quite as neatly correspond to a mathbox node. ↩