feat: resolve workspace from CLAUDE_PROJECT_DIR (base-mcp + hooks)#1
Open
mh0pe wants to merge 1 commit into
Open
feat: resolve workspace from CLAUDE_PROJECT_DIR (base-mcp + hooks)#1mh0pe wants to merge 1 commit into
mh0pe wants to merge 1 commit into
Conversation
Prefer CLAUDE_PROJECT_DIR when set and non-blank; fall back to the existing __dirname/HOOK_DIR relative resolution unchanged. Never throws on missing env var. Affected: src/packages/base-mcp/index.js and all six auto-register hooks (active, backlog, base-pulse-check, operator, satellite-detection, psmm-injector) plus apex-insights.py. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Author
|
Related PRs — part of a coordinated cross-repo offer (
Reviewing them together is recommended; the same change pattern is mirrored per repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
base-mcp and the BASE hooks resolve their workspace root by walking up from
__dirname/HOOK_DIR.parent.parent(apex-insights: 3 levels). This layersCLAUDE_PROJECT_DIRahead of each existing default, across:WORKSPACE_PATHWhen
CLAUDE_PROJECT_DIRis set it is used; otherwise the existing relative resolution is preserved exactly.Why
Data-safety + relocatability: prevents reading/writing a
.basestore outside the user's project when the code is relocated. Claude Code setsCLAUDE_PROJECT_DIR.Notes
import oswhere missing.🤖 Generated with Claude Code