refactor: change type of logger#2165
Merged
Merged
Conversation
zyzyzyryxy
approved these changes
Jun 1, 2026
Contributor
zyzyzyryxy
left a comment
zyzyzyryxy
left a comment
There was a problem hiding this comment.
LGTM in general, build should catch remaining missed calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change aligns most of our logger allowing them to be omitted when needed meaning code inside the args will not be executed unconditionally - example
logger?.(JSON.stringy(X)).Currently only changes the type, while in a follow up I will remove the
debugpackage and update the file logs.