Skip to content

chore(ci): fix ruff import-sorting across repo (46 files)#57

Merged
ChunkyTortoise merged 1 commit into
mainfrom
chore/ci-rehab-ruff-imports-2026-05-23
May 23, 2026
Merged

chore(ci): fix ruff import-sorting across repo (46 files)#57
ChunkyTortoise merged 1 commit into
mainfrom
chore/ci-rehab-ruff-imports-2026-05-23

Conversation

@ChunkyTortoise
Copy link
Copy Markdown
Owner

Summary

Clears 46 pre-existing ruff I001 (import block un-sorted) violations that were blocking the Code Quality Checks job on every open PR (#48 through #56). Auto-fix only, no logic changes.

Scope

  • 43 test files in advanced_rag_system/tests/, tests/, ghl_real_estate_ai/tests/, insight_engine/tests/
  • 3 non-test files (trivial 1-line whitespace / blank-line trims):
    • advanced_rag_system/hybrid_search.py
    • ghl_real_estate_ai/streamlit_demo/components/customer_intelligence_dashboard.py
    • conftest.py (root)

Total: 46 files, 25 insertions, 60 deletions (85 lines touched).

auto-claude/ is excluded by pyproject.toml [tool.ruff].exclude, so its 157 I001 errors are intentionally not in CI scope and not fixed here.

Method

uv tool run ruff@0.15.14 check . --select I --fix

ruff 0.15.14 pinned to match CI (requirements-dev.txt resolves to that version). Local ruff 0.6.9 does not flag these errors. Future repo work should use ruff>=0.15.14 to match CI behavior.

Before / After

  • Before (origin/main): ruff check . -> Found 46 errors.
  • After: ruff check . -> All checks passed!

Out of scope

ruff format --check . is also failing on 44 unrelated files. That's a separate cleanup and not addressed here. The Code Quality Checks job will still fail at the format step until that is fixed in a follow-up.

Test plan

  • ruff check . clean on this branch
  • git diff reviewed: only import-block re-ordering and blank-line removal, no functional changes
  • 3 non-test diffs spot-checked: all 1-line trims, no logic touched
  • CI Code Quality Checks step Run ruff check passes on this PR
  • Confirm no test imports broke (unit tests run as part of CI)

Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com

46 pre-existing I001 violations across test files and 3 non-test files
blocked all PR CI runs. Applied ruff 0.15.14 --fix --select I to the
full repo. Mechanical change, no logic touched.

Breakdown:
- 43 test files (advanced_rag_system/tests/, tests/, ghl_real_estate_ai/tests/, insight_engine/tests/)
- 3 non-test files with 1-line whitespace/blank-line trims:
  - advanced_rag_system/hybrid_search.py
  - ghl_real_estate_ai/streamlit_demo/components/customer_intelligence_dashboard.py
  - conftest.py (root)

Verified: ruff check . is now clean. (ruff format --check is still red
for 44 unrelated files; out of scope for this PR.)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@ChunkyTortoise ChunkyTortoise merged commit 0e21d17 into main May 23, 2026
8 of 12 checks passed
@ChunkyTortoise ChunkyTortoise deleted the chore/ci-rehab-ruff-imports-2026-05-23 branch May 23, 2026 18:39
ChunkyTortoise added a commit that referenced this pull request May 23, 2026
ruff format --check was red on ~44 files unrelated to recent PRs.
This is the second of two CI rehab PRs (first was #57 for import
sorting). All changes are mechanical formatter output, no logic
touched. auto-claude/ excluded per pyproject.toml.

Co-authored-by: Cayman <chunktort@gmail.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants