Open
Conversation
weltonfelix
reviewed
Apr 9, 2024
Member
weltonfelix
left a comment
weltonfelix
left a comment
There was a problem hiding this comment.
The null checks only works if those properties are empty strings.
Also, String.chartAt() always return a string. I.e. "".charAt(0) returns "", so "" ?? "-" will always return "".
src/components/UserPopup/index.tsx
Outdated
| <UserPopUp> | ||
| <UserPopUpContainer> | ||
| <StyledAvatar alt={user.name[0] ?? user.username?.charAt(0)}> | ||
| <StyledAvatar alt={user.name[0] ?? user.username?.charAt(0) ?? '-'}> |
Member
There was a problem hiding this comment.
This line continues to throw an error if user or user.name is null or undefined.
src/lib-components/Navbar/index.tsx
Outdated
| color='inherit' | ||
| > | ||
| <Avatar sx={{ bgcolor: '#db1e2f' }} alt={profile.name[0]}> | ||
| <Avatar sx={{ bgcolor: '#db1e2f' }} alt={profile.name[0] ?? '-'}> |
Member
There was a problem hiding this comment.
The same thing here. If profile.name is null or undefined this code will throw an error.
src/lib-components/Navbar/index.tsx
Outdated
| color='inherit' | ||
| > | ||
| <Avatar sx={{ bgcolor: '#db1e2f' }} alt={profile.name[0]}> | ||
| <Avatar sx={{ bgcolor: '#db1e2f' }} alt={profile.name[0] ?? '-'}> |
antoniomarcelob
force-pushed
the
feature/fix-conditional-name-in-avatar
branch
from
7750953 to
1887516
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.