feat(config): add useSSHIdentityFile user config option#338
Open
michael-webster wants to merge 2 commits into
Open
feat(config): add useSSHIdentityFile user config option#338michael-webster wants to merge 2 commits into
michael-webster wants to merge 2 commits into
Conversation
Long-running Claude sessions would get stuck waiting on SSH_AUTH_SOCK approval prompts for each sidecar connection. Add a user-settable boolean (chunk config set useSSHIdentityFile true) that prefers the default chunk identity file (~/.ssh/chunk_ai) over the SSH agent, avoiding repeated auth prompts in hook context. Also print a warning when remote validate commands fail silently so the error is visible rather than just causing an unexplained exit code 2. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… errors - Add UseSSHIdentityFile to ResolvedConfig so config show reuses the already-loaded config rather than calling config.Load() a second time with a silently swallowed error - Surface DefaultKeyPath() error as a warning instead of discarding it when useSSHIdentityFile is set - Remove misleading warning: print before remote run errors that are already returned as hard failures to the caller Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
A few things from Claude:
The Column alignment broken in
Missing test coverage The test plan describes manual steps but the automated tests don't cover the new paths:
|
schurchleycci
approved these changes
May 22, 2026
Contributor
|
This looks good aside from the above comment 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useSSHIdentityFileas a user config key, letting users opt in to using the default chunk SSH identity file (viasidecar.DefaultKeyPath()) when opening SSH sessions to sidecars, instead of relying onSSH_AUTH_SOCKUseSSHIdentityFilethroughResolvedConfigsoconfig showdisplays it consistently alongside other fieldsDefaultKeyPath()failures as warnings and removes a misleadingwarning:print that preceded a hard-error returnTest plan
chunk config set useSSHIdentityFile true/false— verify accepted values and error on invalid inputchunk config show— verifyuseSSHIdentityFileappears in outputchunk validatewithuseSSHIdentityFile=trueand no identity file present — verify warning is printed and SSH falls back to auth sock behaviorgo test -race ./internal/cmd/... ./internal/config/...🤖 Generated with Claude Code