Migrate sidecar client to V3 API#364
Open
danmux wants to merge 1 commit into
Open
Conversation
Switch all sidecar endpoints from /api/v2/sidecar/ to /api/v3/sidecar/. Resource-creation requests (create sidecar, create snapshot) now send V3 data envelopes; scoped actions (exec, add-key) stay flat. Responses decoded from V3 envelope using pre-initialized typed pointers. Add GetCommand method. Update fakes and all tests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
z00b
approved these changes
May 28, 2026
z00b
reviewed
May 28, 2026
Contributor
z00b
left a comment
z00b
left a comment
There was a problem hiding this comment.
looks like ListSnapshots is still on /v2/
|
|
||
| id := c.Param("id") | ||
| for _, s := range f.Snapshots { | ||
| c.JSON(http.StatusOK, gin.H{ |
Contributor
There was a problem hiding this comment.
claude tells me that moving this c.JSON outside of the if s.ID == id clause changes the intent.
| } | ||
| }) | ||
|
|
||
| t.Run("omits all param by default", func(t *testing.T) { |
Contributor
There was a problem hiding this comment.
this name is not quite accurate now?
| return &Sidecar{ | ||
| ID: env.Data.ID, | ||
| Name: attrs.Name, | ||
| OrgID: refs.Org.ID, |
Contributor
There was a problem hiding this comment.
do we not want the image value in here as well?
| sc.OrgID = id | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/v2/sidecar/to/api/v3/sidecar/GetCommandmethod🤖 Generated with Claude Code