fix(release): comma-separate cargo-packager --formats (deb,appimage)#85
Open
Kyle-Falconer wants to merge 1 commit into
Open
fix(release): comma-separate cargo-packager --formats (deb,appimage)#85Kyle-Falconer wants to merge 1 commit into
Kyle-Falconer wants to merge 1 commit into
Conversation
The dry-run (run 27251211856) failed the linux-portable job with "unrecognized subcommand 'appimage'": cargo-packager has subcommands, so clap stops collecting `--formats` at the first space and reads `appimage` as a subcommand. Comma-separated `deb,appimage` is the correct multi-format syntax (verified locally — both bundles start packaging). rpm + macOS jobs already passed and produced artifacts. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #84. The first
workflow_dispatchdry-run (run 27251211856) failed the linux-portable job:cargo-packager has subcommands, so clap stops collecting
--formatsat the first space and readsappimageas a subcommand. The fix is the comma-separated multi-format syntax:--formats deb,appimage. (My pre-merge local check only used a single format, which is why it slipped through.)Validated on real runners
Dry-run on this branch (run 27251756932) — every job green:
So the full ADR 0022 / #55 matrix now produces
.rpm+.deb+.AppImage+.dmgon a dispatch, Windows skips cleanly, and a realv*tag would publish the draft Release.actionlintclean.Closes #55.
🤖 Generated with Claude Code