feat: add OAuth2 bearer token auth and fix CI secret exposure#331
Merged
Conversation
Adds AMD EPYC CBS tokens, Front NVMe slots 25-32, GPU Direct, Intel TDX, Memory/IO/PCIe, Security/ACPI, Serial/PCR, and speculative_lock_enable parameters. Closes CiscoDevNet#324 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add test_bios_policy_new_tokens with 30+ of the 61 new BIOS tokens covering Intel VT-d, GPU Direct, PCIe, memory/power, AMD CBS, POST, NVMe slot, and misc categories - Tests creation, idempotency, info verification, and update - Verify key API response fields (IntelVtForDirectedIo, ResizeBarSupport) - Add to cleanup lists and update policy count assertions
stevefulme1
force-pushed
the
fix/ci-secret-exposure
branch
from
267b765 to
5413b2e
Compare
…tern Upstream removed 'default: platform-default' from both DOCUMENTATION and argument_spec for BIOS parameters. Aligns new params with this convention to fix ansible-test sanity doc-default-does-not-match-spec errors.
stevefulme1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The workflow
info.ymlpassesANSIBLE_API_KEYdirectly as a CLI argument via--extra-vars, which exposes the secret in process listings and CI logs.This change moves the secret into an environment variable and references it from the shell, preventing the secret value from appearing in the command line.
Before
ansible-playbook ... --extra-vars "ansible_api_key=${{ secrets.ANSIBLE_API_KEY }}" ...After
Risk
Low -- only changes how the secret is passed, not what the playbook receives.