Skip to content

fix(bios_policy): add missing BIOS token params breaking CI#333

Merged
dsoper2 merged 1 commit into
CiscoDevNet:mainfrom
ronger4:fix/ci_bios
Jun 2, 2026
Merged

fix(bios_policy): add missing BIOS token params breaking CI#333
dsoper2 merged 1 commit into
CiscoDevNet:mainfrom
ronger4:fix/ci_bios

Conversation

@ronger4
Copy link
Copy Markdown
Collaborator

@ronger4 ronger4 commented Jun 2, 2026

SUMMARY

  • Add 9 missing BIOS token parameters (cbs_cmn_cpu_avx512, cbs_cmn_mem_speed_ddr47xx2, gpu_direct_cpu1/2, sha384pcr_bank, slot_front_nvme25/26 link_speed/option_rom) to DOCUMENTATION, argument_spec, and bios_property_map in the intersight_bios_policy module
  • Add bios_property_map entries for 32 params from PR Add 61 missing BIOS token parameters #327 that were added to DOCUMENTATION and argument_spec but never wired into the API mapping, causing them to be silently ignored
  • Fixes the weekly regression CI failure: "Unsupported parameters" error at task "Create BIOS policy with new token parameters"

ISSUE TYPE

  • Bug Fix Pull Request

COMPONENT NAME

  • plugins/modules/intersight_bios_policy.py

ADDITIONAL INFORMATION

  • The 9 missing argument_spec entries caused Ansible to reject the parameters outright ("Unsupported parameters" error)
  • The 32 missing bios_property_map entries meant those parameters were accepted by Ansible but never sent to the Intersight API
  • Parameter choices sourced from the Intersight API spec (Pulumi registry / Cisco BIOS token docs)
  • No new tests needed; existing integration tests in tests/integration/targets/intersight_bios_policy/ cover all 9 parameters

Add 9 BIOS parameters to DOCUMENTATION, argument_spec, and
bios_property_map that were used in integration tests but never
added to the module (cbs_cmn_cpu_avx512, cbs_cmn_mem_speed_ddr47xx2,
gpu_direct_cpu1/2, sha384pcr_bank, slot_front_nvme25/26 link_speed
and option_rom).

Also add bios_property_map entries for 32 params from PR CiscoDevNet#327 that
were added to DOCUMENTATION and argument_spec but omitted from the
map, preventing them from being sent to the Intersight API.
@ronger4 ronger4 requested a review from dsoper2 June 2, 2026 08:48
Copy link
Copy Markdown
Collaborator

@dsoper2 dsoper2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsoper2 dsoper2 merged commit 53af5ef into CiscoDevNet:main Jun 2, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants