Review suggestions for [TAN-7898] Generic MCP update tool#14121
Open
adessy wants to merge 8 commits into
Open
Conversation
…::Runner` Adds `:ordering` to the `attrs` allowlist for reorderable types and drops the `:reorder` config key, the `attributes.delete(:ordering)&.to_i` extraction, the dedicated `rejected << :ordering` branch, and the separate `record.insert_at` call. `acts_as_list` 1.2.6 reshuffles siblings on direct assignment to the position column, so `record.update!(ordering: N)` is equivalent to `record.insert_at(N)`.
…to the gem Adds `type: 'object'`, `minProperties: 1`, and a `propertyNames` enum on `attributes` so the `mcp` gem rejects unknown keys, empty hashes, and non-objects before `Runner#run` is invoked. Drops the redundant guards. Description now lists the allowed `attributes` keys per type explicitly, since per-type enforcement isn't possible at the schema layer: top-level `oneOf`/`allOf`/`anyOf` in `input_schema` are rejected by the tool-use API.
Memoizes `record` so `#run` stops re-fetching it on every reference, drops the self-referential pointer in the `attributes` schema description, and refreshes the file-top and `RESOURCES` comments.
Constrains `location_point_geojson` to actual Point shape (`type` const `'Point'`, 2-element `coordinates`, no extras). Allows `null` on `maximum_attendees` with a `minimum: 1` floor. Reorders `address_1` next to `address_2_multiloc`.
…ld descriptions `using_url` was declared `boolean` but the column is a `:string` URL. Rewrites both `online_link` and `using_url` descriptions to make the distinction explicit (event location vs. Attend-button target).
adessy
changed the title
adessy
changed the title
adessy
changed the title
adessy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review suggestions for #14069
Changelog
For translators