Minor enhancements PR#9
Open
IronhideIvan wants to merge 3 commits into
Open
Conversation
added 3 commits
January 22, 2020 11:14
Fiserv uses the ".inc" extension for all of their SQR reporting libraries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
There were certain missing syntax highlighting pieces in our development environment here at Redstone Consulting Group.
One of the dependency libraries we use belong to an organization called Firserv, and they like to add the ".inc" extension to all of their files. I do not know if this is a unique use-case for us only, but I thought that I'd include it since it required us to hack around this extension. I can take it out if you feel it's too specific a modification.
We use a lot of local procedures in out SQR reports, so global variables must be referenced using an underscore like so:
These weren't being highlighted so I added an additional rule to address global variables.
Let me know what y'all think and if there are any changes to my PR you'd like to see.
Thanks!