Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a sample pull request (PR).
Following BDITTO's pull request template, PR descriptions should include:
#<NUMBER>. GitHub will then automatically add links to the corresponding issue(s).These can be answered in sentences or in point form, so long as it is clear and concise for the reader. For example:
In addition to the text, the PR should be assigned reviewers and assignees. The reviewer should be whomever has been assigned to review your work (this PR doesn't have a reviewer because GitHub doesn't let a user review their own work). The assignees should be whomever is responsible for making further changes to the PR, most likely yourself and the reviewer.
The PR should also be labelled, at least with the same labels as for its corresponding issue. See the labels for #1. You may also be required to link the PR to a project or milestone for some projects.