Pebble robustness: ntfy feedback, multi-skill, KB-default cwd#70
Merged
Conversation
Phase 2 over the merged phase-1 webhook (PR #69). Three deltas: - ntfy.sh notification on every terminal outcome, with Claude-emitted JSON tail for title/body; pre-Claude failures notify too. - Multi-skill freedom: drop the single-skill cap, Claude composes. - ~/knowledge_base mounted RW as default cwd; Syncthing handles sync, no git operations in the container. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Replace fictional TimeoutExpired/CalledProcessError with the actual phase-1 exception types (InvocationTimeoutError, UsageLimitError) and the new CliInvocationError that the runner must raise on rc!=0 not matching auth/limit. - Auth-error path (RuntimeError from existing runner) added to failure matrix and worker try/except. - Promote literal /home/clayde/knowledge_base in the system prompt (Claude reads the prompt as text — no ~ expansion). - Clarify parser lives in runner.py as extract_notification_payload(), called from worker; remove conflicting duplicate mention. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Eleven TDD bite-sized tasks covering ntfy notification on every terminal outcome, multi-skill prompt, KB-default cwd, built-in ping skill, and end-to-end integration coverage. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The phase-1 test test_pebble_returns_503_when_full filled the queue and let the 503 branch run unmocked, so the autouse call to send_ntfy hit ntfy.sh on the real network during local test runs. Patch the dispatcher on the app module before invoking the client so the test stays offline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/home/clayde/knowledge_base(RW mount, host-side Syncthing handles cross-device sync — no git inside the container). Built-inpingskill baked into the image at/skills/builtin/lets you sanity-check the whole chain (watch → Traefik → Clayde → ntfy) from the watch.CliInvocationErrorso the worker distinguishes CLI failure from a successful no-summary run. Worker classifies every terminal path into a newpebble.outcomeOTel span attribute:success | claude_fail | parse_fallback | timeout | rate_limited | cli_error | worker_error.CLAYDE_PEBBLE_TIMEOUTdefault lowered 600 → 300 (pocket-dial guard). New env vars:CLAYDE_NTFY_TOPIC,CLAYDE_NTFY_BASE_URL,CLAYDE_NTFY_TIMEOUT_S,CLAYDE_KB_PATH.respx). 363/363 pass on this branch.Spec / plan
Known follow-ups (not in this PR)
Test plan
🤖 Generated with Claude Code