feat(docker): configurable bundled ClickHouse server version#42
Merged
Conversation
Captures the requirements-session decisions for the agent-usable CLI (chfx), configurable bundled server version, binary-dump import, and the standalone capture proxy. Lands on main so subsequent per-item branches inherit the roadmap. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add a global CH_VERSION build arg (default latest) consumed by the runtime stage's FROM, surfaced through docker-compose (CH_VERSION=24.3 docker compose build). Declared before the first FROM so it is in scope for the runtime FROM. Documents usage in the README quick start. Verified: `CH_VERSION=24.3 docker compose build` produces an image whose clickhouse-server --version reports 24.3.18.7. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make the ClickHouse server version bundled in the Docker image configurable, instead of always pinning
clickhouse/clickhouse-server:latest.ARG CH_VERSION=latestdeclared before the firstFROMso it is in scope for the runtime stage'sFROM clickhouse/clickhouse-server:${CH_VERSION}.docker-compose.ymlas a build arg:CH_VERSION=24.3 docker compose build.docker build --build-arg CH_VERSION=...and the compose form. Version is baked at build time.Also lands the CLI/tooling roadmap (
todo.md,docs/cli-spec.md) from the requirements session so subsequent per-item branches inherit it.Why
First item from the roadmap (
todo.md#2). Lets users inspect wire-format behavior against a specific server version rather than only the latest.Testing
docker compose configresolves the arg: defaultlatest, override24.3.CH_VERSION=24.3 docker compose buildsucceeds;clickhouse-server --versioninside the image reports 24.3.18.7.ARGplaced after the firstFROMis stage-scoped, leaving${CH_VERSION}empty in the runtimeFROM; moved it to global scope.🤖 Generated with Claude Code