test(cli): fix flaky proxy integration test (port allocation on main CI)#56
Merged
Merged
Conversation
The proxy integration tests reserved OS-assigned free ports (the ephemeral range, 32768+) and exposed them to containers. Docker publishes container ports from that same range, so testcontainers' own mappings/forwarder could claim a just-released port, and the proxy then failed to bind with EADDRINUSE. With no fast-fail path the listening wait hung 45s and the rejected proxyCommand promise surfaced as an unhandled rejection — the failure seen on the post-merge main run. - Use fixed candidate ports below the ephemeral range (14100+), which the OS won't auto-assign and Docker won't publish to, so they don't race with container port mappings. - Detect a bind failure immediately (capture the early rejection) and retry on the next candidate port instead of waiting out the timeout; this also prevents the unhandled rejection. - Lower the listening-wait timeout to 20s now that bind failures fail fast. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proxy integration tests reserved OS-assigned free ports (the ephemeral range, 32768+) and exposed them to containers. Docker publishes container ports from that same range, so testcontainers' own mappings/forwarder could claim a just-released port, and the proxy then failed to bind with EADDRINUSE. With no fast-fail path the listening wait hung 45s and the rejected proxyCommand promise surfaced as an unhandled rejection — the failure seen on the post-merge main run.