[JDBC-v2] Readonly Profile tests #2883
Merged
Merged
Conversation
|
Repository collaborators can run the JMH benchmark suite against this PR by commenting: Optional regression threshold override (Δ% on Time or Alloc/op; defaults to 10%): Only one benchmark run per PR is active at a time — issuing a new |
chernser
changed the title
TriageCategory: Summary What this impacts
Required reviewer action
|
Client V2 CoverageCoverage Report
Class Coverage
|
JDBC V2 CoverageCoverage Report
Class Coverage
|
JDBC V1 CoverageCoverage Report
Class Coverage
|
Client V1 CoverageCoverage Report
Class Coverage
|
mshustov
approved these changes
Jun 18, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
mshustov
approved these changes
Jun 18, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 74d2073. Configure here.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2760
Checklist
Delete items not relevant to your PR:
Note
Low Risk
Test-only and documentation changes; no driver or public API behavior changes. Integration tests mutate server users/profiles locally and are skipped on cloud.
Overview
Adds integration coverage for ClickHouse
readonlysettings profiles when the JDBC client sends JSON-related server settings (e.g.output_format_binary_write_json_as_string).ReadonlyProfileTestprovisions two users withreadonly=1andreadonly=2, grants SELECT only on the integration test database, and skips on cloud. One case expects a connection/query failure whenreadonly=1blocks overriding settings; the other expects success underreadonly=2with experimental JSON enabled.JdbcDataTypeTests.testJSONReadnow asserts JSON columns fromgetObject()areMapinstances and checks keys/values explicitly (including empty{}).docs/ai-review.mdadds reviewer notes for tests that create users, use GRANT, and handle passwords.Reviewed by Cursor Bugbot for commit c170d3d. Bugbot is set up for automated code reviews on this repo. Configure here.