feat: add prometheus port to the keeper headless service#226
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the missing Prometheus metrics port to the operator-managed ClickHouse Keeper headless Service, enabling Prometheus/ServiceMonitor scraping without requiring users to create and maintain a separate Service (Fixes #224).
Changes:
- Exposes a named
prometheusTCP port on the Keeper headless Service. - Maps the Service port to
PortPrometheusScrape(9090) as the target port.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Operator CI / openshift-compat (pull_request) is failing, but it is not required to merge as infra is not stable yet. |
|
Docs PR opened: ClickHouse/mintlify-docs-dev#202 Synced upstream clickhouse-operator docs: added monitoring and scaling guides, External Secret section, AdditionalPort API, and minor edits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Prometheus port was missing from the Keeper Service ports list
What
Add missing port declaration
Related Issues
Fixes #224