feat: add registry option to helm charts#227
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a configurable image registry prefix to both the operator Helm chart and the clickhouse-cluster Helm chart, allowing users to route all image pulls through a single mirror/proxy (via global.imageRegistry), while still supporting per-image overrides.
Changes:
- Add
global.imageRegistryto operator and cluster chart values to support a shared registry prefix. - Add per-image
image.registrysettings (manager/clickhouse/keeper) withglobal.imageRegistrytaking precedence when set. - Update templates to prepend the configured registry prefix to rendered image repositories.
Reviewed changes
Copilot reviewed 1 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/gen-cluster-chart/templates/values.yaml.tmpl | Extends generated cluster chart values to include global.imageRegistry plus clickhouse/keeper image registry+repository knobs. |
| dist/chart/values.yaml | Documents and exposes global.imageRegistry and manager.image.registry for the operator chart. |
| dist/chart/templates/manager/manager.yaml | Prepends the resolved registry prefix to the manager image repository during rendering. |
| dist/chart-cluster/values.yaml | Exposes global.imageRegistry and per-component image registry+repository values for the cluster chart. |
| dist/chart-cluster/templates/keeper-cluster.yaml | Injects computed keeper image repository (with optional registry prefix) into CR defaults. |
| dist/chart-cluster/templates/clickhouse-cluster.yaml | Injects computed clickhouse image repository (with optional registry prefix) into CR defaults. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Docs PR opened: ClickHouse/mintlify-docs-dev#206 Synced upstream operator docs verbatim, adding monitoring, scaling, and TLS guides plus updates to configuration, introduction, overview, and API reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
An easier way to specify the image registry mirror
What
Support global/local registry option in both operator/cluster charts
Related Issues
Fixes #219