Skip to content

Add ESMValTool ENSO diagnostics#320

Merged
lewisjared merged 14 commits intoClimate-REF:mainfrom
bouweandela:enso-diagnostics
May 26, 2025
Merged

Add ESMValTool ENSO diagnostics#320
lewisjared merged 14 commits intoClimate-REF:mainfrom
bouweandela:enso-diagnostics

Conversation

@bouweandela
Copy link
Contributor

@bouweandela bouweandela commented May 21, 2025

Description

Add ESMValTool ENSO diagnostics

Sample data available in Climate-REF/ref-sample-data#37

Closes #225

Checklist

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Changelog item added to changelog/

@bouweandela
Copy link
Contributor Author

At least some of the test failures are because I had to use a newer version of ESMValTool. I opened #325 to update ESMValTool. It would be great if we could get that merged first.

@bouweandela
Copy link
Contributor Author

I've updated the hashes of the recipes, but this may invalidate the regression tests until #325 has been merged. The tests also require a new release of the sample data that includes Climate-REF/ref-sample-data#37.

@bouweandela bouweandela marked this pull request as ready for review May 25, 2025 19:53
@codecov
Copy link

codecov bot commented May 26, 2025

Codecov Report

❌ Patch coverage is 97.77778% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/climate-ref/src/climate_ref/testing.py 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
...src/climate_ref_esmvaltool/diagnostics/__init__.py 100.00% <100.00%> (ø)
...ool/src/climate_ref_esmvaltool/diagnostics/base.py 100.00% <100.00%> (ø)
...ool/src/climate_ref_esmvaltool/diagnostics/enso.py 100.00% <100.00%> (ø)
...ckages/climate-ref/src/climate_ref/cli/datasets.py 96.55% <ø> (ø)
packages/climate-ref/src/climate_ref/testing.py 63.26% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bouweandela
Copy link
Contributor Author

@lewisjared This is now up to date with the latest version of the sample data, so should be ready to merge

@lewisjared lewisjared merged commit 78388ee into Climate-REF:main May 26, 2025
10 checks passed
@bouweandela bouweandela deleted the enso-diagnostics branch May 27, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implementation of ESMValTool ENSO metrics

2 participants