Remove the use of out_name

[lewisjared]

Description

• Simplified the extraction of variable mappings from the CMIP7 Data Request
• Removed out_name usages
• Don't fallback to defaults when defining filenames and drs

Checklist

Please confirm that this pull request has done the following:

• Tests added
• Documentation added (where applicable)
• Changelog item added to changelog/

[codecov]

Codecov Report

❌ Patch coverage is 93.93939% with 4 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...te-ref-core/src/climate_ref_core/cmip6_to_cmip7.py	93.22%	4 Missing ⚠️

Flag	Coverage Δ
core	93.20% <93.93%> (+0.04%)	⬆️
providers	89.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...limate-ref-core/src/climate_ref_core/esgf/cmip7.py	93.85% <100.00%> (+0.05%)	⬆️
...ages/climate-ref/src/climate_ref/datasets/cmip7.py	85.71% <ø> (ø)
...ages/climate-ref/src/climate_ref/models/dataset.py	98.93% <ø> (ø)
...te-ref-core/src/climate_ref_core/cmip6_to_cmip7.py	94.50% <93.22%> (+1.57%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[lewisjared]

@bouweandela this will cause duplicate test data now following all of the DRS /.cache/climate-ref can be deleted as the converted files now also use the common cache dir (/.cache/climate_ref)

[bouweandela]

Somehow my data always seems to end up with f1, even when the input data has f2

[lewisjared]

Fall back to using value parsed from variant label, but it could also because convert_variant_index explicitly checks for int so numpy ints fail. Either way its more defensive now

[bouweandela]

I compared the results with what CMOR generates. It is fairly similar, except for the issue with the name of the primary variable.

I also noticed that the output from the REF contains a scalar height coordinate on the bounds variables, which does not look right. For example:

netcdf tas_tmaxavg-h2m-hxy-u_mon_glb_gn_UKESM1-0-LL_historical_r1i1p1f2_185001-194912 {
dimensions:
	time = UNLIMITED ; // (1200 currently)
	bnds = 2 ;
	lat = 144 ;
	lon = 192 ;
variables:
	double time_bnds(time, bnds) ;
		time_bnds:_FillValue = NaN ;
		time_bnds:coordinates = "height" ;
...
	double height ;
		height:_FillValue = NaN ;
		height:units = "m" ;
		height:axis = "Z" ;
		height:positive = "up" ;
		height:long_name = "height" ;
		height:standard_name = "height" ;

note the line time_bnds:coordinates = "height" ;

[lewisjared]

I learnt something about xarray today with that spurious bound!

[bouweandela]

Looks good, thanks!