Skip to content

chore(deps): update dependency typescript to v6 #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
renovate wants to merge 1 commit into from
Closed

chore(deps): update dependency typescript to v6 #481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop

@devin-ai-integration devin-ai-integration Bot Apr 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Multiple peer dependency upper bounds exclude TypeScript 6

Beyond the lockfile being stale, even after running npm install, the following packages have peer dependency constraints that reject TypeScript 6.0.2:

  • @typescript-eslint/* (7 packages): >=4.8.4 <6.0.0
  • ts-jest@29.4.6: >=4.3 <6
  • eslint-plugin-jest: >=4.8.4 <6.0.0
  • Some nested @typescript-eslint/* in packages/eslint-plugin: >=4.8.4 <5.9.0

This means a simple lockfile regeneration won't be sufficient — these dependencies also need to be upgraded to versions that support TypeScript 6, or the install will fail with ERESOLVE errors. This is a major-version TypeScript bump that likely requires a coordinated upgrade of the tooling ecosystem.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment thread
devin-ai-integration[bot] marked this conversation as resolved.

@devin-ai-integration devin-ai-integration Bot Apr 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Renovate may have failed to update the lockfile

This PR was authored by renovate[bot] (git show HEAD confirms). Renovate typically updates both package.json and package-lock.json in the same commit. The fact that only package.json was changed suggests either Renovate's lockfile maintenance is misconfigured (check .github/renovate.json), or npm install failed during Renovate's PR creation — possibly because peer dependency conflicts prevented a clean install. This warrants checking the Renovate logs and configuration.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"ts-node": "11.0.0-beta.1",
"tsx": "4.21.0",
"typedoc": "0.28.18",
"typescript": "5.9.3"
"typescript": "6.0.2"
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.
Comment thread
devin-ai-integration[bot] marked this conversation as resolved.

@devin-ai-integration devin-ai-integration Bot Apr 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Major version bump may require code changes across the monorepo

TypeScript 6.0 is a major version bump that likely includes breaking changes (removed deprecated APIs, stricter type checking, changed compiler behavior). While this PR only touches package.json, the monorepo contains many TypeScript packages (packages/*/src) that may need code adjustments. The typecheck script (package.json:32) runs tsgo --project tsconfig.lint.json --noEmit which would catch type errors, but there may also be runtime behavioral differences. The PR should ideally include evidence that npm run all (build, lint, test for all packages) passes after the upgrade.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@devin-ai-integration devin-ai-integration Bot Apr 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 @typescript-eslint 8.57.1 peer dependency violated by TypeScript 6.0.2 (<6.0.0 required)

All @typescript-eslint/* packages at version 8.57.1 (resolved in the lockfile) declare peerDependencies.typescript: ">=4.8.4 <6.0.0". Bumping TypeScript to 6.0.2 violates this constraint. These packages are used for ESLint-based linting via @nx/eslint in per-package lint targets (run through nx run-many --targets lint), so incompatibility could cause lint failures across the monorepo.

Affected packages from package-lock.json 
node_modules/@typescript-eslint/eslint-plugin: v8.57.1, ts peerDep=>=4.8.4 <6.0.0
node_modules/@typescript-eslint/parser: v8.57.1, ts peerDep=>=4.8.4 <6.0.0
node_modules/@typescript-eslint/typescript-estree: v8.57.1, ts peerDep=>=4.8.4 <6.0.0
(and other @typescript-eslint/* packages)

These are peer dependencies of packages/eslint-config/package.json which declares "@typescript-eslint/eslint-plugin": "^8.46.4" and "@typescript-eslint/parser": "^8.46.4".

Prompt for agents 
The TypeScript 6.0.2 upgrade violates the @typescript-eslint/* 8.57.1 peer dependency constraint of 'typescript: >=4.8.4 <6.0.0'. These packages are used for ESLint linting across the monorepo. Either: (1) upgrade @typescript-eslint/* to a version that supports TypeScript 6 (check https://github.com/typescript-eslint/typescript-eslint/releases), or (2) hold off on the TypeScript 6 upgrade until compatible @typescript-eslint versions are available. The relevant peer dependency declarations are in packages/eslint-config/package.json.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment on lines 70 to +73

@devin-ai-integration devin-ai-integration Bot Apr 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Coexistence of typescript and @typescript/native-preview

The repo has both "typescript": "6.0.2" and "@typescript/native-preview": "7.0.0-dev.20260401.1" (package.json:52) in devDependencies. The typecheck script uses tsgo (from the native preview). Having both is likely intentional (standard tsc for build/jest, tsgo for type checking), but after a major version bump it's worth confirming they remain compatible and don't conflict in module resolution or type evaluation.

(Refers to lines 52-73)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

},
"overrides": {
"@anthropic-ai/claude-agent-sdk": {
Expand Down
Loading