Conversation
Dimo-2562
requested changes
Apr 6, 2026
Contributor
Dimo-2562
left a comment
Dimo-2562
left a comment
There was a problem hiding this comment.
수고하셨습니다!! 리뷰 읽어보시고 선택적으로 반영해주세요!
src/test/java/umc/cockple/demo/domain/contest/integration/ContestIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/umc/cockple/demo/domain/contest/integration/ContestIntegrationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/umc/cockple/demo/domain/contest/integration/ContestIntegrationTest.java
Show resolved
Hide resolved
src/test/java/umc/cockple/demo/domain/contest/service/ContestCommandServiceTest.java
Show resolved
Hide resolved
| .andExpect(jsonPath("$.data.contestImgs[0].imgOrder").value(1)) | ||
| .andExpect(jsonPath("$.data.contestVideos").isArray()) | ||
| .andExpect(jsonPath("$.data.contestVideos", hasSize(1))) | ||
| .andExpect(jsonPath("$.data.UpdatedAt").isNotEmpty()); |
Contributor
There was a problem hiding this comment.
이거 DTO 필드명이 카멜 케이스가 아닌 거 같아서 수정하면 좋을 것 같습니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❤️ 기능 설명
단위테스트 - command
단위테스트 - query
통합테스트
추후 별도의 이슈로 코드 리팩토링(함수명이 의미에 맞지 않는 부분, dto를 과도하게 사용하는 부분) 을 진행하겠습니다.
연결된 issue
연결된 issue를 자동으로 닫기 위해 아래 {이슈넘버}를 입력해주세요.
close #565
🩷 Approve 하기 전 확인해주세요!
✅ 체크리스트