Support sparse checkouts in git Source#649
Open
igor-makarov wants to merge 1 commit intoCocoaPods:masterfrom
Open
Support sparse checkouts in git Source#649igor-makarov wants to merge 1 commit intoCocoaPods:masterfrom
igor-makarov wants to merge 1 commit intoCocoaPods:masterfrom
Conversation
dnkoutso
reviewed
Sep 21, 2020
segiddins
reviewed
Sep 22, 2020
| def pod_path(name) | ||
| specs_dir.join(*metadata.path_fragment(name)) | ||
| path = specs_dir.join(*metadata.path_fragment(name)) | ||
| add_to_sparse_checkout(path) if sparse_checkout? |
Member
There was a problem hiding this comment.
it feels very weird to me that simply querying for the path would have side effects
Contributor
Author
There was a problem hiding this comment.
Well, it helps to view it as a "lazy" repo - the code simply ensures that the path can be queried correctly.
If viewed this way, it's not a "side effect" but a necessary implementation detail.
Another way to do this is to add the call to #add_to_sparse_checkout everywhere the path is being queried, but that increases the risk of bugs. My proposition seems more robust to me.
igor-makarov
force-pushed
the
sparse-git
branch
from
b90d00f to
c6aca89
Compare
igor-makarov
force-pushed
the
sparse-git
branch
from
c6aca89 to
a8b030e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This year, git and GitHub have added support for sparse checkouts and partial clones.
This PR adds support for these features in the spec repos. If a spec repo is added as a sparse checkout, (addition is handled in CocoaPods#10069), only the pods the user requests are fetched/checked out.