fix: catch-all skip for per-repo errors and cleaner report format#30
Merged
packet-mover merged 1 commit intomainfrom Apr 12, 2026
Merged
fix: catch-all skip for per-repo errors and cleaner report format#30packet-mover merged 1 commit intomainfrom
packet-mover merged 1 commit intomainfrom
Conversation
- Any non-rate-limit per-repo error now skips the repo instead of aborting the entire scan (GetTree, GetRulesets, GetBranchProtection) - Replace Skipped/SkipReason/SkipError fields with KnownSkipReason and UnknownSkipError (mutually exclusive) plus Skipped() method - Known skip reasons render as plain bullet points in the report - Unknown errors render as bullet points with inline error message - Add per-repo error maps to mock client (ProtectionErrs, RulesetsErrs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skipped bool/SkipReason/SkipErrorfields onRepoResultwithKnownSkipReasonandUnknownSkipError(mutually exclusive) plus aSkipped()methodProtectionErrsandRulesetsErrsmaps for per-repo error injectionFollow-up to #28. One flaky repo no longer kills the entire scan.
Test plan
go test ./...- all 79 tests pass