Skip to content

Separate styling from tsx components#290

Open
lyannne wants to merge 8 commits intomainfrom
separate-styling-from-tsx-components
Open

Separate styling from tsx components#290
lyannne wants to merge 8 commits intomainfrom
separate-styling-from-tsx-components

Conversation

@lyannne
Copy link
Collaborator

@lyannne lyannne commented Feb 5, 2026

ℹ️ Issue

Closes #280

📝 Description

  1. Changed CSS styles at bottom of the file to Tailwind styling for Login.tsx, Register.tsx, and RegisterLanding.tsx.
  2. Removed Account.tsx and Profile.tsx files since they were unused
  3. Minor changes to GrantCalculations.text.tsx to fix an error I was getting with the structure of the data.
  4. Added top margin to button on RegisterLanding.tsx for a better look.

✔️ Verification

N/A (pages look same as before)

Test Changes

N/A

🏕️ (Optional) Future Work / Notes

  • For the Register page (Register.tsx), the height of the page shortened a bit when I changed the styles to Tailwind, but it shouldn't be noticeable.

Copilot AI review requested due to automatic review settings February 5, 2026 06:14
@lyannne lyannne linked an issue Feb 5, 2026 that may be closed by this pull request
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR converts inline CSS styles to Tailwind classes for several authentication-related components, removes unused files, and fixes test data structure to match the actual implementation.

Changes:

  • Converted inline styles to Tailwind classes in Login.tsx, Register.tsx, and RegisterLanding.tsx
  • Removed unused Account.tsx and Profile.tsx files
  • Fixed test assertions in GrantCalculations.test.tsx to match the actual data structure returned by the implementation

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
frontend/src/Login.tsx Removed inline style object and converted styles to Tailwind classes
frontend/src/Register.tsx Removed inline style object and converted error/warning styles to conditional Tailwind classes
frontend/src/RegisterLanding.tsx Removed inline style object and converted to Tailwind classes, added margin to button
frontend/src/Account.tsx Deleted unused component file
frontend/src/Profile.tsx Deleted unused component file
frontend/tests/GrantCalculations.test.tsx Fixed test expectations to match implementation's data structure with nested data property

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@janekamata janekamata self-requested a review February 5, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEV - Separate styling from tsx components

1 participant