Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR converts inline CSS styles to Tailwind classes for several authentication-related components, removes unused files, and fixes test data structure to match the actual implementation.
Changes:
- Converted inline styles to Tailwind classes in
Login.tsx,Register.tsx, andRegisterLanding.tsx - Removed unused
Account.tsxandProfile.tsxfiles - Fixed test assertions in
GrantCalculations.test.tsxto match the actual data structure returned by the implementation
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/Login.tsx | Removed inline style object and converted styles to Tailwind classes |
| frontend/src/Register.tsx | Removed inline style object and converted error/warning styles to conditional Tailwind classes |
| frontend/src/RegisterLanding.tsx | Removed inline style object and converted to Tailwind classes, added margin to button |
| frontend/src/Account.tsx | Deleted unused component file |
| frontend/src/Profile.tsx | Deleted unused component file |
| frontend/tests/GrantCalculations.test.tsx | Fixed test expectations to match implementation's data structure with nested data property |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #280
📝 Description
Login.tsx,Register.tsx, andRegisterLanding.tsx.Account.tsxandProfile.tsxfiles since they were unusedGrantCalculations.text.tsxto fix an error I was getting with the structure of the data.RegisterLanding.tsxfor a better look.✔️ Verification
N/A (pages look same as before)
Test Changes
N/A
🏕️ (Optional) Future Work / Notes
Register.tsx), the height of the page shortened a bit when I changed the styles to Tailwind, but it shouldn't be noticeable.