Skip to content

Minor cleanup fixes #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brysonbw merged 2 commits into from
Dec 7, 2025
Merged

Minor cleanup fixes #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b122dd7
update default volume param value
brysonbw Dec 7, 2025
40af543
lint/fix file
brysonbw Dec 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
## Change(s)

<!-- ✏️ Describe *what* was changed in this PR. Be as clear and specific as possible. -->
<!-- 📝 Note: Please try to use bullet points and/or numbered list.
<!-- 📝 Note: Please try to use bullet points and/or numbered list.

**Example**

Expand Down
11 changes: 4 additions & 7 deletions src/services/web-audio-api.service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
import {
AUDIO_SOUND,
AUDIO_VOLUME,
CLIENT_ERROR_MESSAGE,
} from '../utils/constants.js';
import { DEFAULT_SETTINGS } from '../stores/settings.js';
import { AUDIO_SOUND, CLIENT_ERROR_MESSAGE } from '../utils/constants.js';

class WebAudioApiService {
/** @type {AudioContext | undefined} */
Expand Down Expand Up @@ -59,7 +56,7 @@ class WebAudioApiService {
* @param {number} volume
* @returns {GainNode}
*/
#createGain(volume = AUDIO_VOLUME.ONE_HUNDRED_PERCENT) {
#createGain(volume = DEFAULT_SETTINGS.audioVolume) {
const gainNode = /** @type {GainNode} */ (this.#audioContext?.createGain());
gainNode.gain.value = Math.min(Math.max(volume / 100, 0), 1);
const destination = /** @type {AudioDestinationNode} */ (
Expand All @@ -74,7 +71,7 @@ class WebAudioApiService {
* @param {number} volume
* @returns {Promise<void>}
*/
async playSound(id, volume = AUDIO_VOLUME.ONE_HUNDRED_PERCENT) {
async playSound(id, volume = DEFAULT_SETTINGS.audioVolume) {
if (!this.#audioContext) {
console.error(
`${CLIENT_ERROR_MESSAGE.PLAY_SOUND_FAILED} AudioContext unavailable.`
Expand Down
Loading