Hmt 103 check in time confirmation was really long and sometimes buggy#206
Open
justin-phxm wants to merge 4 commits intomainfrom
Open
Hmt 103 check in time confirmation was really long and sometimes buggy#206justin-phxm wants to merge 4 commits intomainfrom
justin-phxm wants to merge 4 commits intomainfrom
Conversation
There was a problem hiding this comment.
Copilot reviewed 27 out of 29 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- amplify/auth/PostConfirmation/amplify_outputs.json: Language not supported
- amplify/function/BusinessLogic/_amplify_model/amplify_outputs.json: Language not supported
Comments suppressed due to low confidence (2)
src/app/register/team/(pending)/new/page.tsx:29
- The comment indicates that the addCallerToTeam flag is set to false due to an issue in the lambda function. Consider addressing the underlying lambda bug or documenting the workaround more clearly.
addCallerToTeam: false, // broken in lambda function.
src/components/Dashboard/DevPostLinkUpload.tsx:63
- [nitpick] Consider adding an aria-label to the submit button to improve accessibility.
<button type="submit" className="border-1 rounded-full border-red-500 ">
Comment on lines
+85
to
+87
| teamId = generateTeamId(); | ||
| ({ error: teamIdTaken } = await tryCatch(getTeamFromId(teamId))); | ||
| } // possibility of infite loop at 36^4 teams |
There was a problem hiding this comment.
Consider adding a maximum iteration limit in the team ID generation loop to prevent a potential infinite loop in edge cases.
Suggested change
| teamId = generateTeamId(); | |
| ({ error: teamIdTaken } = await tryCatch(getTeamFromId(teamId))); | |
| } // possibility of infite loop at 36^4 teams | |
| if (iterationCount >= MAX_ITERATIONS) { | |
| throw new Error( | |
| JSON.stringify({ | |
| body: { value: `Unable to generate unique team ID after ${MAX_ITERATIONS} attempts` }, | |
| statusCode: 500, | |
| headers: { "Content-Type": "application/json" }, | |
| }), | |
| ); | |
| } | |
| teamId = generateTeamId(); | |
| ({ error: teamIdTaken } = await tryCatch(getTeamFromId(teamId))); | |
| iterationCount++; | |
| } |
4ea1c4b to
49baa6c
Compare
49baa6c to
3bcd414
Compare
3bcd414 to
06bc31e
Compare
Contributor
|
HEY @justin-phxm FIX THIS NEXT BUILD NOW!!! |
…y-long-and-sometimes-buggy
df33111 to
2ffe7e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://uofc-my.sharepoint.com/:v:/g/personal/justin_pham_ucalgary_ca/ETEHqqLQRjtBoaQ7PAn0FUMBMpQNAbLc26c5Pefyz7c8Fg?e=MBzla7
remove checkin field. Add devpost link field.