Fix for duplicate values using setState with initially selected items#16
Open
mogelbuster wants to merge 1 commit intoCodeFoxLk:masterfrom
Open
Fix for duplicate values using setState with initially selected items#16mogelbuster wants to merge 1 commit intoCodeFoxLk:masterfrom
mogelbuster wants to merge 1 commit intoCodeFoxLk:masterfrom
Conversation
Fix for duplicate values appearing for each call to setState when initializing MultiSelectContainer with pre-selected items.
larakreisz
added a commit
to larakreisz/flutter_multi_select
that referenced
this pull request
May 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for duplicate values appearing for each call to setState when initializing MultiSelectContainer with pre-selected items. For example when initializing
MultiSelectContainerlike this:In the above example I am setting some of the initial
_myItemstoselected: truebased on their existence in_mySelectedItems.The reason the selected values were being duplicated is because
didUpdateWidgetwould call_addInitiallySelectedItemsToSelectedListwhich would blindly add those items to_selectedItems. This is OK ininitStatebecause it is only called once when the widget is created. But it is a problem indidUpdateWidgetbecause it is called whenever the widget is updated, thus adding the same items to_selectedItemsagain and again.