(feat) Add Screen Reader Support to MultiSelectContainer#17
Open
mogelbuster wants to merge 1 commit intoCodeFoxLk:masterfrom
Open
(feat) Add Screen Reader Support to MultiSelectContainer#17mogelbuster wants to merge 1 commit intoCodeFoxLk:masterfrom
mogelbuster wants to merge 1 commit intoCodeFoxLk:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the iOS screen reader would just say the text on the multi select item, but not say if it was toggleable and also not say the current state. This change allows the screen reader to say all of that information. I only added screen reader support to the default Text widget and not to the custom child widget functionality because for the custom widget a user can include their own screen reader support if desired.