London | 25-SDC-July | Andrei Filippov | Sprint 2 | Implement a linked list in Python #28
+50
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Droid-An
added
the
Needs Review
cjyuan
reviewed
Jan 25, 2026
|
|
||
| def push_head(self, element): | ||
| node = Node(element) | ||
| if self.head and self.tail: |
There was a problem hiding this comment.
Is it necessary to check also self.tail?
| node.next = self.head | ||
| self.head.previous = node | ||
| self.head = node | ||
| elif not self.head and not self.tail: |
There was a problem hiding this comment.
This line could probably be simplified.
Comment on lines
+29
to
+41
| if self.head != node and self.tail != node: | ||
| node.previous.next = node.next | ||
| node.next.previous = node.previous | ||
| node.previous, node.next = None, None | ||
| elif self.head == node and self.tail != node: | ||
| node.next.previous = None | ||
| self.head = node.next | ||
| node.previous, node.next = None, None | ||
| elif self.head != node and self.tail == node: | ||
| node.previous.next = None | ||
| self.tail = node.previous | ||
| node.previous, node.next = None, None | ||
| elif self.head == node and self.tail == node: |
There was a problem hiding this comment.
The conditions can be simplified (reduce the amount of checking needed) as:
if self.head == node:
if self.tail == node:
# Case 1: head == node, tail == node
else:
# Case 2: head == node, tail != node
else;
if self.tail == node:
# Case 3: head != node, tail == node
else:
# Case 4: head != node, tail != nodeOnly two comparisons needed.
cjyuan
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implemented a linked list in Python.
Questions
no questions