Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions Sprint-2/improve_with_caches/fibonacci/fibonacci.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,13 @@
cache = {}

def fibonacci(n):
if n in cache:
return cache[n]

if n <= 1:
return n
return fibonacci(n - 1) + fibonacci(n - 2)
result = n
else:
result = fibonacci(n - 1) + fibonacci(n - 2)

cache[n] = result
return result

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is good.

17 changes: 14 additions & 3 deletions Sprint-2/improve_with_caches/making_change/making_change.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,24 @@ def ways_to_make_change(total: int) -> int:

For instance, there are two ways to make a value of 3: with 3x 1 coins, or with 1x 1 coin and 1x 2 coin.
"""
return ways_to_make_change_helper(total, [200, 100, 50, 20, 10, 5, 2, 1])
# Cache to store computed results
cache = {}
return ways_to_make_change_helper(total, [200, 100, 50, 20, 10, 5, 2, 1], cache)


def ways_to_make_change_helper(total: int, coins: List[int]) -> int:
def ways_to_make_change_helper(total: int, coins: List[int], cache: dict) -> int:
"""
Helper function for ways_to_make_change to avoid exposing the coins parameter to callers.
"""
if total == 0 or len(coins) == 0:
return 0

# Create cache key from current state
cache_key = (total, tuple(coins))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

converting the list to a tuple every time is going to be expensive. Also at each stage you're creating a new list, which will also be expensive. The new lists are always the same list, but starting later. Can you think of a way you could refactor the code so that it always uses the same tuple, and the recursion is achieved by passing a parameter indicating where the first usable entry in the tuple is? In that situation, how much can you simplify the key to the cache as well?


if cache_key in cache:
return cache[cache_key]

ways = 0
for coin_index in range(len(coins)):
coin = coins[coin_index]
Expand All @@ -26,7 +34,10 @@ def ways_to_make_change_helper(total: int, coins: List[int]) -> int:
if total_from_coins == total:
ways += 1
else:
intermediate = ways_to_make_change_helper(total - total_from_coins, coins=coins[coin_index+1:])
intermediate = ways_to_make_change_helper(total - total_from_coins, coins=coins[coin_index+1:], cache=cache)
ways += intermediate
count_of_coin += 1

# Store result in cache
cache[cache_key] = ways
return ways