-
-
Notifications
You must be signed in to change notification settings - Fork 14
London | 25-SDC-July | Ali Qassab | Sprint 2 | Improve code with caches #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,13 @@ | ||
| cache = {} | ||
|
|
||
| def fibonacci(n): | ||
| if n in cache: | ||
| return cache[n] | ||
|
|
||
| if n <= 1: | ||
| return n | ||
| return fibonacci(n - 1) + fibonacci(n - 2) | ||
| result = n | ||
| else: | ||
| result = fibonacci(n - 1) + fibonacci(n - 2) | ||
|
|
||
| cache[n] = result | ||
| return result | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,16 +7,24 @@ def ways_to_make_change(total: int) -> int: | |
|
|
||
| For instance, there are two ways to make a value of 3: with 3x 1 coins, or with 1x 1 coin and 1x 2 coin. | ||
| """ | ||
| return ways_to_make_change_helper(total, [200, 100, 50, 20, 10, 5, 2, 1]) | ||
| # Cache to store computed results | ||
| cache = {} | ||
| return ways_to_make_change_helper(total, [200, 100, 50, 20, 10, 5, 2, 1], cache) | ||
|
|
||
|
|
||
| def ways_to_make_change_helper(total: int, coins: List[int]) -> int: | ||
| def ways_to_make_change_helper(total: int, coins: List[int], cache: dict) -> int: | ||
| """ | ||
| Helper function for ways_to_make_change to avoid exposing the coins parameter to callers. | ||
| """ | ||
| if total == 0 or len(coins) == 0: | ||
| return 0 | ||
|
|
||
| # Create cache key from current state | ||
| cache_key = (total, tuple(coins)) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. converting the list to a tuple every time is going to be expensive. Also at each stage you're creating a new list, which will also be expensive. The new lists are always the same list, but starting later. Can you think of a way you could refactor the code so that it always uses the same tuple, and the recursion is achieved by passing a parameter indicating where the first usable entry in the tuple is? In that situation, how much can you simplify the key to the cache as well? |
||
|
|
||
| if cache_key in cache: | ||
| return cache[cache_key] | ||
|
|
||
| ways = 0 | ||
| for coin_index in range(len(coins)): | ||
| coin = coins[coin_index] | ||
|
|
@@ -26,7 +34,10 @@ def ways_to_make_change_helper(total: int, coins: List[int]) -> int: | |
| if total_from_coins == total: | ||
| ways += 1 | ||
| else: | ||
| intermediate = ways_to_make_change_helper(total - total_from_coins, coins=coins[coin_index+1:]) | ||
| intermediate = ways_to_make_change_helper(total - total_from_coins, coins=coins[coin_index+1:], cache=cache) | ||
| ways += intermediate | ||
| count_of_coin += 1 | ||
|
|
||
| # Store result in cache | ||
| cache[cache_key] = ways | ||
| return ways | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is good.