Skip to content

London | 25-SDC-July | Eyuel Abraham | Sprint 3 | Middleware exercises #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
eyuell21 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

London | 25-SDC-July | Eyuel Abraham | Sprint 3 | Middleware exercises #37

eyuell21 wants to merge 4 commits into from

Conversation

@eyuell21
Copy link

@eyuell21 eyuell21 commented Oct 17, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Middleware implementations.

Questions

No questions.

@github-actions
Copy link

github-actions bot commented Oct 17, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@eyuell21 eyuell21 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 17, 2025
LonMcGregor
LonMcGregor reviewed Oct 28, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, though I have a suggestion of something to think about to help practise writing even more reusable middleware

Custom-Middlewares/script.js
const parsed = JSON.parse(data);
if (
!Array.isArray(parsed) ||
!parsed.every(item => typeof item === 'string')
Copy link

@LonMcGregor LonMcGregor Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the goal of this middleware - it seems to do two things.

Here you're combining JSON parsing and checking the input is strings. As middleware aims to allow re-use of code, what change could you make to this that would allow you to re-use these separate checks more easily?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eyuell21 @LonMcGregor