ZA | 25-SDC-July | Luke Manyamazi | Sprint 3 | Middleware Exercises #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Luke-Manyamazi wants to merge 1 commit into CodeYourFuture:main from Luke-Manyamazi:middleware

Luke-Manyamazi commented Oct 25, 2025 •

edited

Loading

Middleware-custom: Express app with two custom-written middlewares (username and JSON array parser)
Middleware-offTheShelf: Express app replacing JSON parser with Express's built-in middleware

Both apps handle POST requests and return authentication and subject info messages

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have added code for all middleware exercises

Questions

I do not have any questions.


          Added two new directories:

  1. Middleware-custom: Express app with two custom-written middlewares (username and JSON array parser)
  2. Middleware-offTheShelf: Express app replacing JSON parser with Express's built-in middleware
- Both apps handle POST requests and return authentication and subject info messages

Luke-Manyamazi added the Needs Review label

github-actions bot commented Oct 25, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

5 similar comments

github-actions bot commented Oct 25, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions bot commented Oct 25, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions bot commented Oct 25, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions bot commented Oct 25, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions bot commented Oct 25, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

Luke-Manyamazi added the Module-Decomposition label

LonMcGregor reviewed

View reviewed changes

LonMcGregor left a comment

Looking good, though I have a suggestion of something to think about to help practise writing even more reusable middleware

Middleware-custom/app.js

+                  // Simple string check
+                  for (let item of req.body) {
+                    if (typeof item !== 'string') {
+                      return res.status(400).send('Error: All items must be strings');

LonMcGregor Oct 28, 2025

What is the goal of this middleware - it seems to do two things.

Here you're combining JSON parsing and checking the input is strings. As middleware aims to allow re-use of code, what change could you make to this that would allow you to re-use these separate checks more easily?

LonMcGregor added Reviewed and removed Needs Review labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Decomposition Reviewed