Skip to content

London | Rihanna Poursoltani | Module-Decomposition | Sprint 4 | Laptop allocation #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
RihannaP wants to merge 4 commits into
base: main
Choose a base branch
from
Open

London | Rihanna Poursoltani | Module-Decomposition | Sprint 4 | Laptop allocation #57

RihannaP wants to merge 4 commits into from

Conversation

@RihannaP
Copy link

@RihannaP RihannaP commented Oct 26, 2025 •
edited
Loading

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

@RihannaP RihannaP added 📅 Sprint 4 Assigned during Sprint 4 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 26, 2025
LonMcGregor
LonMcGregor reviewed Oct 28, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, there are far too many files committed here for this task. Can you take another look at this PR and make sure you're only committing what is necessary?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 28, 2025
@RihannaP
Revert "Intial setup"
94ab8dd 
This reverts commit 94faa6d.
LonMcGregor
LonMcGregor reviewed Oct 29, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this sprint's tasks, I have spotted a few areas where you could improve code further

@RihannaP RihannaP added the Complete Volunteer to add when work is complete and all review comments have been addressed. label Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 4 Assigned during Sprint 4 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RihannaP @LonMcGregor