Skip to content

Sheffield | 26-Jan-ITP | Mona_Eltantawy | Sprint 1 | Wireframe #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Mona-Eltantawy wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Sheffield | 26-Jan-ITP | Mona_Eltantawy | Sprint 1 | Wireframe #1053

Mona-Eltantawy wants to merge 9 commits into from

Conversation

@Mona-Eltantawy
Copy link

@Mona-Eltantawy Mona-Eltantawy commented Jan 24, 2026 •
edited
Loading

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Semantic HTML tags( like: article, div, img) are used to structure the webpage.
  • Added header includes a title and description to the page.
  • three unique articles, each including a title, summary, and a link has been added to the articles section.
  • Fixed the page footer to the bottom of the viewport.
  • The linked .css style file changed to fit the html file.
  • added properly committed and pushed to a branch on GitHub.

@netlify
Copy link

netlify bot commented Jan 24, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 133b6a3
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6976a83bf91f390008217785
😎 Deploy Preview https://deploy-preview-1053--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
@Mona-Eltantawy Mona-Eltantawy added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
@cjyuan cjyuan changed the title Sheffield | 26-Jan-ITP | Mona_Eltantawy | Sprint1 | Onboarding- Wireframe Sheffield | 26-Jan-ITP | Mona_Eltantawy | Sprint 1 | Wireframe Jan 24, 2026
@Mona-Eltantawy Mona-Eltantawy added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 24, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Jan 25, 2026

  • Some of the checkboxes in the PR description are not yet properly encoded in Markdown syntax. Can you fix the Markdown syntax?

  • Lighthouse accessibility score is 92. Can you improve the score to 100?

    • Reason given by Lighthouse: Background and foreground colors do not have a sufficient contrast ratio.

  • There are some minor consistency issues in index.html.

    • Suggestion: share your code to an AI tool and ask it to review your code in terms of semantic, accessibility, typo, and consistency. It can often help us catch errors, improve consistency, and reinforce best practices.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 25, 2026
@Mona-Eltantawy
changed the header and footer background and forground colors to have…
133b6a3 
… more sufficient contrast ratio.

changed the emantic aand typo issues.
@Mona-Eltantawy
Copy link
Author

Mona-Eltantawy commented Jan 25, 2026

  • I have shared the code with an AI tool and reviewed the issues you mentioned and rechecked the code using Lighthouse and the accessibility now is 100%.

@Mona-Eltantawy Mona-Eltantawy added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 25, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Jan 25, 2026

Changes look great. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 25, 2026
@Mona-Eltantawy
Copy link
Author

Mona-Eltantawy commented Jan 26, 2026

Changes look great. Well done.

Thank you😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Mona-Eltantawy @cjyuan