West Midlands | 25-May-ITP | Toluwalase Tiamiyu | Sprint 2 | Coursework#1428
Open
TTiamiyu wants to merge 28 commits into
Open
West Midlands | 25-May-ITP | Toluwalase Tiamiyu | Sprint 2 | Coursework#1428TTiamiyu wants to merge 28 commits into
TTiamiyu wants to merge 28 commits into
Conversation
…g out the initials
… values in a loop
…or identification in percentage change calculation
…, and calculations in time formatting
…e pence to pounds conversion process
…date predictions and explanations
…correct their implementations
… and explanations
…lanations for pad function calls
…c and add comprehensive test cases
This comment has been minimized.
This comment has been minimized.
4 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
LonMcGregor
reviewed
Jul 6, 2026
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work. There is one file you could improve a bit more
|
|
||
| function calculateBMI(weight, height) { | ||
| const bmi = weight / (height * height); | ||
| return Math.round(bmi * 10) / 10; |
There was a problem hiding this comment.
Here you are multiplying by 10 then dividing by 10, which seems like a complex solution. Is there an easier function you could use to get the 1 decimal place?
Author
There was a problem hiding this comment.
True, i have checked for what i can use and i have switched the code to "toFixed(1) instead.
| return `${hours - 12}:00 pm`; | ||
| const minutes = time.slice(3, 5); | ||
| if (hours >= 12) { | ||
| const pmHours = String(hours === 12 ? 12 : hours - 12).padStart(2, "0"); |
LonMcGregor
reviewed
Jul 7, 2026
LonMcGregor
left a comment
There was a problem hiding this comment.
Great, that makes the code much cleaner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
In this sprint i worked on Comparisons, assertions, and breaking down problems.