Skip to content

West Midlands | 25-May-ITP | Toluwalase Tiamiyu | Sprint 2 | Coursework#1428

Open
TTiamiyu wants to merge 28 commits into
CodeYourFuture:mainfrom
TTiamiyu:coursework/Sprint-2
Open

West Midlands | 25-May-ITP | Toluwalase Tiamiyu | Sprint 2 | Coursework#1428
TTiamiyu wants to merge 28 commits into
CodeYourFuture:mainfrom
TTiamiyu:coursework/Sprint-2

Conversation

@TTiamiyu

@TTiamiyu TTiamiyu commented Jun 29, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

In this sprint i worked on Comparisons, assertions, and breaking down problems.

TTiamiyu added 25 commits June 13, 2026 02:42
…or identification in percentage change calculation
@github-actions

This comment has been minimized.

4 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@TTiamiyu TTiamiyu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 29, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 29, 2026
@github-actions

This comment has been minimized.

@TTiamiyu TTiamiyu added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 30, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 30, 2026
@github-actions

This comment has been minimized.

@TTiamiyu TTiamiyu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 30, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 30, 2026
@TTiamiyu TTiamiyu changed the title Birmingham | 25-ITP-May | Toluwalase Tiamiyu | Sprint 2 | Coursework Birmingham | 25-May-ITP | Toluwalase Tiamiyu | Sprint 2 | Coursework Jun 30, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@TTiamiyu TTiamiyu changed the title Birmingham | 25-May-ITP | Toluwalase Tiamiyu | Sprint 2 | Coursework West Midlands | 25-May-ITP | Toluwalase Tiamiyu | Sprint 2 | Coursework Jun 30, 2026
@github-actions

This comment has been minimized.

@TTiamiyu TTiamiyu added 🏕 Priority Mandatory This work is expected Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 3, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. There is one file you could improve a bit more

Comment thread Sprint-2/3-mandatory-implement/1-bmi.js Outdated

function calculateBMI(weight, height) {
const bmi = weight / (height * height);
return Math.round(bmi * 10) / 10;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you are multiplying by 10 then dividing by 10, which seems like a complex solution. Is there an easier function you could use to get the 1 decimal place?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, i have checked for what i can use and i have switched the code to "toFixed(1) instead.

return `${hours - 12}:00 pm`;
const minutes = time.slice(3, 5);
if (hours >= 12) {
const pmHours = String(hours === 12 ? 12 : hours - 12).padStart(2, "0");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of a ternary expression

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 6, 2026
@TTiamiyu TTiamiyu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 7, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, that makes the code much cleaner

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 🏕 Priority Mandatory This work is expected Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants