Skip to content

London | 26-ITP-May | Tomislav Dukez | Sprint 2 | Coursework#1430

Open
tomdu3 wants to merge 14 commits into
CodeYourFuture:mainfrom
tomdu3:coursework/sprint-2
Open

London | 26-ITP-May | Tomislav Dukez | Sprint 2 | Coursework#1430
tomdu3 wants to merge 14 commits into
CodeYourFuture:mainfrom
tomdu3:coursework/sprint-2

Conversation

@tomdu3

@tomdu3 tomdu3 commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Tasks of the Sprin2 of the Course Work for the Module Structuring and Testing Data

@tomdu3 tomdu3 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 🏕 Priority Mandatory This work is expected 📅 Sprint 2 Assigned during Sprint 2 of this module labels Jun 30, 2026
LonMcGregor
LonMcGregor reviewed Jul 6, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Well done attempting the stretch task. I have a couple of comments where you could improve a bit more

Comment thread Sprint-2/3-mandatory-implement/1-bmi.js Outdated
Comment thread Sprint-2/5-stretch-extend/format-time.js Outdated
@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 6, 2026
@tomdu3

tomdu3 commented Jul 6, 2026

Copy link
Copy Markdown
Author

awesome. Yeah, I have redundant slicing I could have done at the beginning and just insert the values later after conditional checks. thanks.

@tomdu3 tomdu3 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 6, 2026
LonMcGregor
LonMcGregor reviewed Jul 7, 2026
View reviewed changes

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, code is much simpler now. Your task is complete

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 🏕 Priority Mandatory This work is expected 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomdu3 @LonMcGregor