London | 25-ITP-May | Tomislav Dukez | Sprint 3 | Implement and Rewrite Tests#1437
Open
tomdu3 wants to merge 12 commits into
Open
London | 25-ITP-May | Tomislav Dukez | Sprint 3 | Implement and Rewrite Tests#1437tomdu3 wants to merge 12 commits into
tomdu3 wants to merge 12 commits into
Conversation
tomdu3
added
🏕 Priority Mandatory
tomdu3
changed the title
LonMcGregor
reviewed
Jul 6, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work. One comment about your fractions testing, though
LonMcGregor
added
Reviewed
tomdu3
commented
Jul 6, 2026
tomdu3
left a comment
tomdu3
left a comment
Author
There was a problem hiding this comment.
@LonMcGregor, Of course I've missed that, and naturally - there's a bug. So, I fixed the issue with calculation and added tests with negative numbers.
Awesome review. Thanks.
tomdu3
added
Needs Review
LonMcGregor
reviewed
Jul 7, 2026
|
|
||
| function isProperFraction(numerator, denominator) { | ||
| // TODO: Implement this function | ||
| if (denominator === 0 || Math.abs(numerator / denominator) > 1) { |
There was a problem hiding this comment.
Great work, your test cases for fractions are more expansive now.
My next question is about this if conditional. You are checking something which is a boolean, then returning true/false based on that condition. Can you spot any way you could simplify this code?
LonMcGregor
added
Reviewed
tomdu3
added
Needs Review
LonMcGregor
reviewed
Jul 8, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work fixing this. returning a boolean from an if condition is a common mistake, but it's also pretty easy to fix, so look out for things like this!
LonMcGregor
removed
the
Needs Review
LonMcGregor
added
the
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Added tasks from the Sprint 3, Implement and Rewrite Tests: