Skip to content

Manchester | 26-ITP-May | Szidonia Bodo | Sprint 2 | Coursework#1438

Open
bodoszidi wants to merge 11 commits into
CodeYourFuture:mainfrom
bodoszidi:Sprint-2
Open

Manchester | 26-ITP-May | Szidonia Bodo | Sprint 2 | Coursework#1438
bodoszidi wants to merge 11 commits into
CodeYourFuture:mainfrom
bodoszidi:Sprint-2

Conversation

@bodoszidi

@bodoszidi bodoszidi commented Jul 1, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completed sprint 2 coursework

@github-actions

This comment has been minimized.

@bodoszidi bodoszidi added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Jul 1, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 1, 2026
@github-actions

This comment has been minimized.

3 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@bodoszidi bodoszidi added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 1, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, well done attempting the stretch task. Some of the earlier tasks might have issues, see my comments

//return percentage;
//}

//console.log(convertToPercentage(decimalNumber));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you try to run this test, does it work correctly?

@bodoszidi bodoszidi Jul 7, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct answer will be
function convertToPercentage(decimalNumber) {
const percentage = ${decimalNumber * 100}%;
return percentage;
}

console.log(convertToPercentage(0.45));

we shouldn't declare the decimal number inside the function - as it was already declared as a parameter

// Finally, correct the code to fix the problem
// =============> write your new code here
//function multiply(a, b) {
//return(a * b);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to include these brackets here?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No brackets are needed:
function multiply(a, b) {
return a * b;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work - nice implementation of the pad function.

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 6, 2026
@bodoszidi bodoszidi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 7, 2026
@LonMcGregor

Copy link
Copy Markdown

Good answers. In future, if you have changes, you can commit them and they'll be automatically added on to the PR.

For now, this task is complete

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Structuring-And-Testing-Data The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants