London | 26-ITP-May | Russom Gebremeskel | Sprint 2 | Coursework/sprint 2 by russom-g · Pull Request #1458 · CodeYourFuture/Module-Structuring-and-Testing-Data

russom-g · 2026-07-04T15:18:58Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I manage to predict, find, interpret and fix the errors in programs. I debugged each files and corrected the programs. I implemented functions based on requirements. I interpreted programs using documentations.

…sing.

…t different stages.

…function needs fixing.

Liam310 · 2026-07-06T11:52:11Z

+// The return value of pad when it is called for the first time is 00. this is because the value of num is 0 and the pad function adds a 0 to the front of the string until the num characters has at least 2 characters.
+


To be precise, what exactly is the return value of pad? I think you know what it is, but 00 doesn't quite exactly describe it

Hi Liam. Thanks for reviewing my code.
The exact return value is 0 . It ads a single 0 instead of two 0s.

Liam310 · 2026-07-06T11:52:34Z

+
+// The return value of pad when it is called for the last time is 01. This is because the pad function adds a 0 to the front of the string if the characters of the string are less than 2.


Same as above comment!

Again it will be a single 0.

Liam310 · 2026-07-06T11:57:30Z

@@ -1,3 +1,3 @@
 // Predict and explain first...
 //  =============> write your prediction here



There's no benefit in adding a prediction now after you have run the code, but in future make sure you are always reading instructions thoroughly and completing the task as it is described.

Understood.

Liam310 · 2026-07-06T11:57:43Z

+// The error occurred because decimalNumber is declared twice. No need to create the percentage variable too.
+// Instead the expression is returned directly without declaring a new variable.
+// The function should be called with a value passed in as an argument and the result should be stored in a variable to be logged to the console.
+// convertedPercentage is declared to store the result of the function call and then logged to the console.


This is a great explanation of the errors, just bear in mind that the sentence:

No need to create the percentage variable too

is a matter of opinion! No need to comment on the cleanliness of the code here 🙂

That is a good point. I will bear that in the mind when commenting on a code next time :)

Liam310 · 2026-07-06T11:57:52Z

+//The sum of 10 and 32 is undefined
+
+// The above error message is displayed when tested with node.
+// The cause of the error message is the semicolon that is placed after the return statement.


Did this actually cause an error message to be displayed?

It returns '' The sum of 10 and 32 is undefined". Initially I had assumed that this was happening because of the semicolon after return. Now I run the code again this time without the semicolon still get "undefined" message. I did some research online and it is actually not just because of the semicolon but because both the return statement and the expression "a+b" are not on the same line.

Liam310 · 2026-07-06T11:58:06Z

+// 1) The above output (3) is displayed because the variable num is declared as a constant 
+// 2) .slice(-1) is used to get the last digit of num inside the function.
+// 3) The function does not take any parameters so when it is called with an arguments it always returns the last digit of the constant num 103.
+


Would this be different if the variable was declared with let?

No. I realise that the error is actually not because it declared as const. num isn't defined as the function's parameter so the function can take arguments later on when it's called.

Liam310 · 2026-07-06T11:58:17Z

+// Try and describe the purpose / rationale behind each step
+
+// To begin, we can start with
+// 1. const penceString = "399p": initialises a string variable with the value "399p"


These comments are a hangover from the task in Sprint 1 (as are lots of the comments you have in the body of the function) - when copying code (and this goes for any time you do it!) make sure you are only bringing over the relevant stuff, and anything that isn't relevant should be excluded

Liam310 · 2026-07-06T12:01:38Z

+  const currentOutput4 = formatAs12HourClock("12:00");
+  const targetOutput4 = "12:00 pm";
+  console.assert(
+    currentOutput4 === targetOutput4,
+    `current output: ${currentOutput4}, target output: ${targetOutput4}`
+  );
+
+  const currentOutput5 = formatAs12HourClock("00:01");
+  const targetOutput5 = "12:01 am";
+  console.assert(
+    currentOutput5 === targetOutput5,
+    `current output: ${currentOutput5}, target output: ${targetOutput5}`
+  );
+
+  const currentOutput6 = formatAs12HourClock("12:01");
+  const targetOutput6 = "12:01 pm";
+  console.assert(
+    currentOutput6 === targetOutput6,
+    `current output: ${currentOutput6}, target output: ${targetOutput6}`
+  );
+
+  const currentOutput7 = formatAs12HourClock("23:59");
+  const targetOutput7 = "11:59 pm";
+  console.assert(
+    currentOutput7 === targetOutput7,
+    `current output: ${currentOutput7}, target output: ${targetOutput7}`
+  );
+
+  const currentOutput8 = formatAs12HourClock("13:00");
+  const targetOutput8 = "01:00 pm";
+  console.assert(
+    currentOutput8 === targetOutput8,
+    `current output: ${currentOutput8}, target output: ${targetOutput8}`
+  );


This looks like a lot of good tests! Unfortunately, as it stands they don't run - they appear to be nested within the function that is being tested.

You should fix this, make sure your tests are running, see which ones fail (and some of them do fail!) then fix accordingly.

Hint: if you want to check that your tests are running, you can add a temporary test that you know will fail/edit one of your existing tests to make sure it fails. If you don't see any output, then you know the tests aren't running.

I have been stuck with this one an I am trying to figure out ways to fix the issue including asking for help from fellow trainees on slack. I will get back to you with the solution as soon as I figure it out. Thanks

I have fixed the issues with is code now. I removed the curly bracket at the end of the code. I also have fixed the issue with the function and the failing test cases. I commented on the new code lines in the program. Thanks for your time and feedbacks again.

…d added in order to test case for 1:00am to work

russom added 12 commits June 24, 2026 22:15

Error explained. New corrected code provided.

a5e418c

Error explained and corrected.

598d02c

square function error explained and corrected.

6de1b67

A multiply function error explained and code fixed.

10512d8

Error explained and fixed by removing semicolon after return statement.

3772da2

Error explain and fixed on function parameter naming and argument pas…

4bbefef

…sing.

BMI calculator function created.

3ecc9ea

A function created to convert string into upper snake case.

dffd727

A reusable function created from previous sprint.

7e1a0bf

Pad and formatTimeDisplay functions explained what output they have a…

313ea73

…t different stages.

more edge cases added. Assertion has failed. If condition inside the …

45bd5ef

…function needs fixing.

Edge test cases for 24 to 12 hours formatting functions

2e7a6a3

This comment has been minimized.

Sign in to view

russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 4, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 4, 2026

Unwanted file removed

c7ec47c

russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 4, 2026

Liam310 added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 6, 2026

Liam310 reviewed Jul 6, 2026

View reviewed changes

Liam310 removed the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jul 6, 2026

Liam310 added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Jul 6, 2026

russom added 2 commits July 7, 2026 22:31

Minutes variable is added to manipulate the minutes. A padStart metho…

2345af3

…d added in order to test case for 1:00am to work

Comments added

01f907a

		// The return value of pad when it is called for the first time is 00. this is because the value of num is 0 and the pad function adds a 0 to the front of the string until the num characters has at least 2 characters.

		@@ -1,3 +1,3 @@
		// Predict and explain first...
		// =============> write your prediction here

Uh oh!

Uh oh!

Conversation

russom-g commented Jul 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Liam310 Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Liam310 Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

russom-g commented Jul 4, 2026 •

edited

Loading

Liam310 Jul 6, 2026 •

edited

Loading

Liam310 Jul 6, 2026 •

edited

Loading