Skip to content

West Midlands | ITP-26-May| Alina Sofragiu | Sprint 3 | Dead Code#1462

Open
sofragiualina wants to merge 1 commit into
CodeYourFuture:mainfrom
sofragiualina:3-dead-code
Open

West Midlands | ITP-26-May| Alina Sofragiu | Sprint 3 | Dead Code#1462
sofragiualina wants to merge 1 commit into
CodeYourFuture:mainfrom
sofragiualina:3-dead-code

Conversation

@sofragiualina

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • [ x ] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • [ x ] My changes meet the requirements of the task
  • [ x ] I have tested my changes
  • [ x ] My changes follow the style guide

Changelist

Removed unused code

@sofragiualina sofragiualina added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Jul 4, 2026
@Luro91 Luro91 added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Jul 9, 2026

@Luro91 Luro91 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job you got removed most of the redundant or dead code. I have one comment where you can improve the code a bit

console.log(greetingStr);
}

testName = "Aman";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How could the code be changed so that this line is not needed but the variable is still set to "Aman"?

@Luro91 Luro91 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Structuring-And-Testing-Data The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants