London | 26-ITP-May | Edina Kurdi | Sprint 3 | Implement and rewrite tests#1468
Open
edinakurdi wants to merge 6 commits into
Open
London | 26-ITP-May | Edina Kurdi | Sprint 3 | Implement and rewrite tests#1468edinakurdi wants to merge 6 commits into
edinakurdi wants to merge 6 commits into
Conversation
edinakurdi
added
the
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Implemented and tested angles, proper fraction and cards functions, also tested using jest
Questions
With the card implementation, I tried making it cleaner, but nested if-statements are not the best for clean code. Is that correct? Would there be a more structured way of dealing with this? I think I was on the right track with creating the suits array inside the function, but then it got a bit messy. Are there any techniques that would help me gear towards a better solution here?
Also, when trying to write tests, how many of the same kind is enough? for instance, with the cards, would i need to test for each number value when its a number card, or is it enough to test for 2-3 numbers?